887-refactor: Partners refactor #892
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
|
Lighthouse Report:
|
|
Lighthouse Report:
|
YulikK
reviewed
May 14, 2025
|
Lighthouse Report:
|
ansivgit
reviewed
May 15, 2025
src/widgets/partnered/partnered.tsx
Outdated
| <WidgetTitle size="small">Partnered with</WidgetTitle> | ||
| <div className="partners"> | ||
| <div className="partner-logo-container"> | ||
| <ul className={cx('partners')}> |
There was a problem hiding this comment.
Could we use the structure like in Alumni widget?
There was a problem hiding this comment.
I understand a point of keeping a similar HTML structure in all our widgets
Difference for now:
Alumni
<article>
<section>
<WidgetTitle />
<Paragraph />
<section>
{alumni.map(() => (
<figure>
<Image />
</figure>
))}
</section>
</section>
</article>
Partnered
<section>
<div>
<WidgetTitle />
<ul>
{partners.map(() => (
<li>
<Component />
</li>
))}
</ul>
</div>
</section>
- All containers in widgets have
sectiontag. - I't strange to have
article->section->sectionstructure - lists usually use
ul->litags
Therefore, I suggest to keep partnered html structure in both partnered and alumni widgets
YulikK
reviewed
May 15, 2025
|
Lighthouse Report:
|
YulikK
approved these changes
May 27, 2025
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (select all that apply)
Description
Refactor partnered module
Related Tickets & Documents
Screenshots, Recordings
I changed a little bit styles for tablets and mobiles
Added/updated tests?
[optional] Are there any post deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?